]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
regulator: mt6359: Fix vbbck default internal supply name
authorChen-Yu Tsai <wenst@chromium.org>
Tue, 9 Jun 2026 08:36:27 +0000 (16:36 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 9 Jun 2026 18:00:42 +0000 (19:00 +0100)
This issue was pointed out by Sashiko.

vbbck is fed internally from vio18. For the MT6359, the default supply
name was incorrectly set as "VIO18", instead of the supply's default
"VIO18". In practice this still works, but it causes the regulator
description copy and replace to always happen. For the MT6359P the
name is correct.

Fix the supply name for MT6359 so that both instances are the same and
correct. Also copy the comment about the internal supply from the MT6359
list to the MT6359P list.

Fixes: 10be8fc1d534 ("regulator: mt6359: Add regulator supply names")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20260609083630.1600070-1-wenst@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/mt6359-regulator.c

index 7bda382ddd8149edca1da81a81aa0fb46fe9133a..7c3a3ecb36413a44723d15323e15363ac3cdf1fb 100644 (file)
@@ -693,7 +693,7 @@ static const struct mt6359_regulator_info mt6359_regulators[] = {
                   MT6359_RG_VM18_VOSEL_MASK << MT6359_RG_VM18_VOSEL_SHIFT,
                   1920),
        /* vbbck is fed from vio18 internally. */
-       MT6359_LDO("ldo_vbbck", VBBCK, "VIO18", vbbck_voltages,
+       MT6359_LDO("ldo_vbbck", VBBCK, "LDO_VIO18", vbbck_voltages,
                   MT6359_RG_LDO_VBBCK_EN_ADDR, MT6359_RG_LDO_VBBCK_EN_SHIFT,
                   MT6359_DA_VBBCK_B_EN_ADDR, MT6359_RG_VBBCK_VOSEL_ADDR,
                   MT6359_RG_VBBCK_VOSEL_MASK << MT6359_RG_VBBCK_VOSEL_SHIFT,
@@ -926,6 +926,7 @@ static const struct mt6359_regulator_info mt6359p_regulators[] = {
                   MT6359P_DA_VM18_B_EN_ADDR, MT6359P_RG_VM18_VOSEL_ADDR,
                   MT6359_RG_VM18_VOSEL_MASK << MT6359_RG_VM18_VOSEL_SHIFT,
                   1920),
+       /* vbbck is fed from vio18 internally. */
        MT6359_LDO("ldo_vbbck", VBBCK, "LDO_VIO18", vbbck_voltages,
                   MT6359P_RG_LDO_VBBCK_EN_ADDR, MT6359P_RG_LDO_VBBCK_EN_SHIFT,
                   MT6359P_DA_VBBCK_B_EN_ADDR, MT6359P_RG_VBBCK_VOSEL_ADDR,