]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: Don't return -1 as program return value
authorPeter Krempa <pkrempa@redhat.com>
Thu, 4 Mar 2021 17:52:32 +0000 (18:52 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 5 Mar 2021 14:33:34 +0000 (15:33 +0100)
In cases we use -1 for failure internally we still must return
EXIT_FAILURE.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemucommandutiltest.c
tests/virnetdevbandwidthtest.c

index 6291c3b787ea01ef213ffd90bd7308f951dce245..03947d87bc52780ca0c0cca1136b42a759006fa7 100644 (file)
@@ -146,8 +146,7 @@ mymain(void)
                                      "server.2.type=tcp,"
                                      "server.2.host=example.com");
 
-    return ret;
-
+    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }
 
 VIR_TEST_MAIN(mymain)
index 2e76af3d0c8263852d237efbbbaf59a79cc1b39b..6d0443876c9e8b381df71c290dcd1f2d11267222 100644 (file)
@@ -156,7 +156,7 @@ mymain(void)
                  TC " filter add dev eth0 parent ffff: protocol all u32 match u32 0 0 "
                  "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n"));
 
-    return ret;
+    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }
 
 VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virnetdevbandwidth"))