s3:winbindd: Send flags=0 in netr_LogonSamLogon{WithFlags,Ex}()

These extra flags are an [in,out] argument, so we have to initialize
them to 0. If we pass NETLOGON_SAMLOGON_FLAG_PASS_TO_FOREST_ROOT
or NETLOGON_SAMLOGON_FLAG_PASS_CROSS_FOREST_HOP, a Windows Server
will just return NT_STATUS_NO_SUCH_USER with authoritative=1
(at least if it is itself a DC of the forest root and the requested
 domain is the local domain of the DC).

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
index 0b17b78bd6ba3978f6d9c1e85a2912d11def2c34..ff4c93d922186d9139907e710aa655c9164789d0 100644 (file)
--- a/source3/winbindd/winbindd_dual_srv.c
+++ b/source3/winbindd/winbindd_dual_srv.c
@@ -864,7 +864,7 @@ NTSTATUS _winbind_SamLogon(struct pipes_struct *p,
        struct winbindd_domain *domain;
        NTSTATUS status;
        DATA_BLOB lm_response, nt_response;
-       uint32_t flags;
+       uint32_t flags = 0;
 
        domain = wb_child_domain();
        if (domain == NULL) {

diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index 4d3a7eeb1ba9e7ea0a43afd7ec352e2843d6af6f..8abd8f07e021f6837c765fccab4f15bdc4c008c7 100644 (file)
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -2118,8 +2118,8 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
        const char *name_user = NULL;
        const char *name_domain = NULL;
        const char *workstation;
-       uint8_t authoritative;
-       uint32_t flags;
+       uint8_t authoritative = 0;
+       uint32_t flags = 0;
 
        DATA_BLOB lm_resp, nt_resp;