]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
commands/file: Use definitions from arm64/linux.h
authorLeif Lindholm <leif.lindholm@linaro.org>
Mon, 25 Jun 2018 17:01:29 +0000 (18:01 +0100)
committerDaniel Kiper <daniel.kiper@oracle.com>
Wed, 11 Jul 2018 10:02:18 +0000 (12:02 +0200)
Clean up code for matching IS_ARM64 slightly by making use of struct
linux_arm64_kernel_header and GRUB_LINUX_ARM64_MAGIC_SIGNATURE.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/commands/file.c

index ab0c9fb96946fe6078d7e518a93804143ec66d66..3ff6d5522d2d572c2af16fec371faeb8e4b28f9d 100644 (file)
@@ -28,6 +28,7 @@
 #include <grub/xen_file.h>
 #include <grub/efi/pe32.h>
 #include <grub/arm/linux.h>
+#include <grub/arm64/linux.h>
 #include <grub/i386/linux.h>
 #include <grub/xnu.h>
 #include <grub/machoload.h>
@@ -405,13 +406,13 @@ grub_cmd_file (grub_extcmd_context_t ctxt, int argc, char **args)
       }
     case IS_ARM64_LINUX:
       {
-       grub_uint32_t sig;
+       struct linux_arm64_kernel_header lh;
 
-       if (grub_file_seek (file, 0x38) == (grub_size_t) -1)
-         break;
-       if (grub_file_read (file, &sig, 4) != 4)
+       if (grub_file_read (file, &lh, sizeof (lh)) != sizeof (lh))
          break;
-       if (sig == grub_cpu_to_le32_compile_time (0x644d5241))
+
+       if (lh.magic ==
+           grub_cpu_to_le32_compile_time (GRUB_LINUX_ARM64_MAGIC_SIGNATURE))
          {
            ret = 1;
            break;