Fix incorrect sizeof expression in syswrap-xen.c, reported by Coverity (#1233786)

n-i-bz

Reviewed-by: Ian Campbell <ian.campbell@citrix.com>
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15361

diff --git a/NEWS b/NEWS
index 3a6894816c86b8d6aace9806d497a0a8a708b77c..dd2069c97121884459d07a05b8e60e3f2dd6c9dd 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -252,6 +252,7 @@ n-i-bz  Fix compilation on distros with glibc < 2.5
 n-i-bz  (vex 3098) Avoid generation of Neon insns on non-Neon hosts
 n-i-bz  Enable rt_sigpending syscall on ppc64 linux.
 n-i-bz  mremap did not work properly on shared memory
+n-i-bz  Fix incorrect sizeof expression in syswrap-xen.c reported by Coverity
 
 
 Release 3.10.1 (25 November 2014)

diff --git a/coregrind/m_syswrap/syswrap-xen.c b/coregrind/m_syswrap/syswrap-xen.c
index a1e11c9294666384e88975f634bd7e70fcddff09..43951039b7bd75fb5f69fb4da371fec25375a394 100644 (file)
--- a/coregrind/m_syswrap/syswrap-xen.c
+++ b/coregrind/m_syswrap/syswrap-xen.c
@@ -943,7 +943,7 @@ PRE(tmem_op)
          *    vki_uint32_t subop;
          */
         PRE_MEM_READ("__HYPERVISOR_tmem_op pool_id",
-                     (Addr)&tmem->pool_id, sizeof(&tmem->pool_id));
+                     (Addr)&tmem->pool_id, sizeof(tmem->pool_id));
         PRE_XEN_TMEMOP_READ(ctrl, subop);
 
         switch (tmem->u.ctrl.subop) {