iptables: spurious error in load_extension

In commit 927385017047d (iptables: improve error reporting with extension
loading troubles), a new error message was added in an attempt to handle
the case where a match does not support a particular protocol family.
For instance, attempting to use the osf match on IPv6.

Unfortunately, this error message now triggers when creating a new chain
which has the same name as a match extension, because iptables calls
xtables_find_target with the name of the new chain to verify it does not
clash with an existing target.  For example:

    # iptables -N tcp
    /usr/lib/xtables/libxt_tcp.so: no "tcp" extension found for this protocol

I attempted to resolve this by adding a new XTF flag, but that required changes
in many different places (including -j handling).  It seems easiest just to
remove this warning and stick with the original error message of ENOENT, even
if less than precise.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/libxtables/xtables.c b/libxtables/xtables.c
index 8437baf8338b39e1921f15b49cefbdc811b183b6..fb60c01b48c051ce4daf08c58c593be28e4b64ec 100644 (file)
--- a/libxtables/xtables.c
+++ b/libxtables/xtables.c
@@ -578,8 +578,6 @@ static void *load_extension(const char *search_path, const char *af_prefix,
                        if (ptr != NULL)
                                return ptr;
 
-                       fprintf(stderr, "%s: no \"%s\" extension found for "
-                               "this protocol\n", path, name);
                        errno = ENOENT;
                        return NULL;
                }