]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scripts: generate_rust_analyzer.py: avoid FD leak
authorTamir Duberstein <tamird@kernel.org>
Tue, 27 Jan 2026 16:35:43 +0000 (11:35 -0500)
committerTamir Duberstein <tamird@kernel.org>
Mon, 9 Mar 2026 17:20:09 +0000 (13:20 -0400)
Use `pathlib.Path.read_text()` to avoid leaking file descriptors.

Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`")
Cc: stable@vger.kernel.org
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Fiona Behrens <me@kloenk.dev>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Link: https://patch.msgid.link/20260127-rust-analyzer-fd-leak-v2-1-1bb55b9b6822@kernel.org
Signed-off-by: Tamir Duberstein <tamird@kernel.org>
scripts/generate_rust_analyzer.py

index 38e834bd209e0081cbbde692c746b0429d889c65..024e71a742e0873c61ca142b577a1c5e36a60b83 100755 (executable)
@@ -313,9 +313,10 @@ def generate_crates(
 
     def is_root_crate(build_file: pathlib.Path, target: str) -> bool:
         try:
-            return f"{target}.o" in open(build_file).read()
+            contents = build_file.read_text()
         except FileNotFoundError:
             return False
+        return f"{target}.o" in contents
 
     # Then, the rest outside of `rust/`.
     #