Move assignment out of fr_assert_msg() to pacify Coverity (CID #1504180) (#4479)

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index 47c987e64f019e90f5a28604002ec85fa9b04b78..c598f08108091e80224d9a693510a7c12c3d4ea4 100644 (file)
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -877,8 +877,8 @@ static int _module_instance_free(module_instance_t *mi)
                 *
                 *      Assert that the mutex is not held.
                 */
-               fr_assert_msg((ret = pthread_mutex_trylock(&mi->mutex)) == 0,
-                             "Failed locking module mutex during exit: %s", fr_syserror(ret));
+               ret = pthread_mutex_trylock(&mi->mutex);
+               fr_assert_msg(ret == 0, "Failed locking module mutex during exit: %s", fr_syserror(ret));
                pthread_mutex_unlock(&mi->mutex);
 #endif
                pthread_mutex_destroy(&mi->mutex);