]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
datasets: improve 'dataset-add' error checking
authorVictor Julien <victor@inliniac.net>
Mon, 13 Apr 2020 13:47:18 +0000 (15:47 +0200)
committerJeff Lucovsky <jeff@lucovsky.org>
Fri, 24 Apr 2020 14:06:26 +0000 (10:06 -0400)
(cherry picked from commit b80ab56d10d9907e3dcab8cdcd2285c711201de8)

src/runmode-unix-socket.c

index 72a9ed04d0082f1f6f9d5fe8921ebe3f1c465f42..89bdd97d0160ce6c8702783a540cea719d6ccec7 100644 (file)
@@ -667,6 +667,10 @@ TmEcode UnixSocketDatasetAdd(json_t *cmd, json_t* answer, void *data)
     SCLogNotice("dataset-add: %s type %s value %s", set_name, type, value);
 
     enum DatasetTypes t = DatasetGetTypeFromString(type);
+    if (t == DATASET_TYPE_NOTSET) {
+        json_object_set_new(answer, "message", json_string("unknown settype"));
+        return TM_ECODE_FAILED;
+    }
 
     Dataset *set = DatasetFind(set_name, t);
     if (set == NULL) {