]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
parser_bison: simplify error in chain type and hook
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 31 Mar 2020 18:27:52 +0000 (20:27 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 31 Mar 2020 18:28:42 +0000 (20:28 +0200)
Remove extra string after error, location is sufficient.

 # nft -f x
 /tmp/x:3:8-11: Error: unknown chain type
                type nput hook input device eth0 priority 0
                     ^^^^

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/parser_bison.y

index 735f2dffc6e6ee6ca589601341c4a3ea3ff9fb79..3e8d6bd6d8ca32c194f4fde5a086bd079c8fcd06 100644 (file)
@@ -1880,7 +1880,7 @@ flowtable_block           :       /* empty */     { $$ = $<flowtable>-1; }
                                $$->hook.loc = @3;
                                $$->hook.name = chain_hookname_lookup($3);
                                if ($$->hook.name == NULL) {
-                                       erec_queue(error(&@3, "unknown chain hook %s", $3),
+                                       erec_queue(error(&@3, "unknown chain hook"),
                                                   state->msgs);
                                        xfree($3);
                                        YYERROR;
@@ -2049,7 +2049,7 @@ hook_spec         :       TYPE            STRING          HOOK            STRING          dev_spec        prio_spec
                                const char *chain_type = chain_type_name_lookup($2);
 
                                if (chain_type == NULL) {
-                                       erec_queue(error(&@2, "unknown chain type %s", $2),
+                                       erec_queue(error(&@2, "unknown chain type"),
                                                   state->msgs);
                                        xfree($2);
                                        YYERROR;
@@ -2061,7 +2061,7 @@ hook_spec         :       TYPE            STRING          HOOK            STRING          dev_spec        prio_spec
                                $<chain>0->hook.loc = @4;
                                $<chain>0->hook.name = chain_hookname_lookup($4);
                                if ($<chain>0->hook.name == NULL) {
-                                       erec_queue(error(&@4, "unknown chain hook %s", $4),
+                                       erec_queue(error(&@4, "unknown chain hook"),
                                                   state->msgs);
                                        xfree($4);
                                        YYERROR;