Bug 286501: Summarize time fails with "Can't bind reference" error

Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 31b8f49441ce0632bb50f979f991ee18704694cf..86a12155224b0060c3285e596cb0051368065215 100755 (executable)
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -643,7 +643,8 @@ sub AppendComment ($$$;$$$) {
     $dbh->do("UPDATE bugs SET delta_ts = ? WHERE bug_id = ?",
              undef, $timestamp, $bugid);
 }
-
+\r
+# This method is private and is not to be used outside of the Bug class.
 sub EmitDependList {
     my ($myfield, $targetfield, $bug_id) = (@_);
     my $dbh = Bugzilla->dbh;

diff --git a/summarize_time.cgi b/summarize_time.cgi
index ab8a6bf50e766e70922682aa10431473cac3e8e8..6ea31fceb0e16cddc3f25db5b2308171bbf88090 100755 (executable)
--- a/summarize_time.cgi
+++ b/summarize_time.cgi
@@ -203,10 +203,10 @@ sub get_blocker_ids_unique {
 }
 
 sub get_blocker_ids_deep {
-    my ($bug_id, $ret) = @_;
-    my @deps = Bugzilla::Bug::EmitDependList("blocked", "dependson", $bug_id);
-    push @{$ret}, @deps;
-    foreach $bug_id (@deps) {
+    my ($bug_id, $ret) = @_;\r
+    my $deps = Bugzilla::Bug::EmitDependList("blocked", "dependson", $bug_id);
+    push @{$ret}, @$deps;
+    foreach $bug_id (@$deps) {\r
         get_blocker_ids_deep($bug_id, $ret);
     }
 }
@@ -238,7 +238,7 @@ sub query_work_by_buglist {
                       bugs.bug_id = longdescs.bug_id 
                       $date_bits } .
             $dbh->sql_group_by('longdescs.bug_id, profiles.login_name',
-                               'bugs.short_desc, bugs.bug_status') . qq{
+                'bugs.short_desc, bugs.bug_status, longdescs.bug_when') . qq{
                ORDER BY longdescs.bug_when};
     my $sth = $dbh->prepare($q);
     $sth->execute(@{$date_values});