]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
tools: kmod: show wrong command in err message
authorLucas De Marchi <lucas.demarchi@profusion.mobi>
Fri, 23 Dec 2011 13:44:28 +0000 (11:44 -0200)
committerLucas De Marchi <lucas.demarchi@profusion.mobi>
Fri, 23 Dec 2011 13:44:28 +0000 (11:44 -0200)
tools/kmod.c

index 0aec4c36e89bff5fe234b36fb92b5402099bd3b9..ddd12e7d0007d0fe5afb33f2bffcca64420624e2 100644 (file)
@@ -113,26 +113,29 @@ static int handle_kmod_commands(int argc, char *argv[])
        }
 
        if (optind >= argc) {
-               err = -ENOENT;
-               goto finish;
+               fputs("missing command\n", stderr);
+               goto fail;
        }
 
        cmd = argv[optind];
 
-       for (i = 0; i < ARRAY_SIZE(kmod_cmds); i++) {
+       for (i = 0, err = -EINVAL; i < ARRAY_SIZE(kmod_cmds); i++) {
                if (strcmp(kmod_cmds[i]->name, cmd) != 0)
                        continue;
 
                err = kmod_cmds[i]->cmd(--argc, ++argv);
        }
 
-finish:
        if (err < 0) {
-               fputs("missing or unknown command\n", stderr);
-               kmod_help(argc, argv);
+               fprintf(stderr, "invalid command '%s'\n", cmd);
+               goto fail;
        }
 
        return err;
+
+fail:
+       kmod_help(argc, argv);
+       return EXIT_FAILURE;
 }