]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Fix misleading comment for GetOperatorFromCompareType
authorDavid Rowley <drowley@postgresql.org>
Tue, 6 Jan 2026 02:16:56 +0000 (15:16 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 6 Jan 2026 02:16:56 +0000 (15:16 +1300)
The comment claimed *strat got set to InvalidStrategy when the function
lookup fails.  This isn't true; an ERROR is raised when that happens.

Author: Paul A Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://postgr.es/m/CA+renyXOrjLacP_nhqEQUf2W+ZCoY2q5kpQCfG05vQVYzr8b9w@mail.gmail.com
Backpatch-through: 18

src/backend/commands/indexcmds.c

index 22ccbad7d3981dafaab635135104b0416b9d926e..14679ff637370408641d49b1d809443a9b93fdb9 100644 (file)
@@ -2440,8 +2440,8 @@ GetDefaultOpClass(Oid type_id, Oid am_id)
  * Finds an operator from a CompareType.  This is used for temporal index
  * constraints (and other temporal features) to look up equality and overlaps
  * operators.  We ask an opclass support function to translate from the
- * compare type to the internal strategy numbers.  If the function isn't
- * defined or it gives no result, we set *strat to InvalidStrategy.
+ * compare type to the internal strategy numbers.  Raises ERROR on search
+ * failure.
  */
 void
 GetOperatorFromCompareType(Oid opclass, Oid rhstype, CompareType cmptype,