QUIC CHANNEL: Revise inaccurate comments

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19703)

diff --git a/ssl/quic/quic_channel.c b/ssl/quic/quic_channel.c
index b0752cda7905ab8155905af42daf3259162b9e9e..87406f4ee355624915e45e7ef240cf55c79280b0 100644 (file)
--- a/ssl/quic/quic_channel.c
+++ b/ssl/quic/quic_channel.c
@@ -1529,7 +1529,7 @@ int ossl_quic_channel_on_handshake_confirmed(QUIC_CHANNEL *ch)
  *   - If we are already TERMINATED this is a no-op.
  *
  *   - If we are TERMINATING - CLOSING and we have now got a CONNECTION_CLOSE
- *     from the peer (tcause->remote == 1), we move to TERMINATING - CLOSING.
+ *     from the peer (tcause->remote == 1), we move to TERMINATING - DRAINING.
  *
  *   - If we are TERMINATING - DRAINING, we remain here until the terminating
  *     timer expires.

diff --git a/ssl/quic/quic_channel_local.h b/ssl/quic/quic_channel_local.h
index 269781688f6e493fdf7baa81ad236a36ae31bd2c..a16422e6e1957e58b8eb3648bdf6dd66807e112b 100644 (file)
--- a/ssl/quic/quic_channel_local.h
+++ b/ssl/quic/quic_channel_local.h
@@ -246,9 +246,12 @@ struct quic_channel_st {
     unsigned int                    have_qsm                : 1;
 
     /*
-     * Preferred EL for transmission. This is not strictly needed as it can be
-     * inferred from what keys we have provisioned, but makes determining the
-     * current EL simpler and faster.
+     * Preferred ELs for transmission and reception. This is not strictly needed
+     * as it can be inferred from what keys we have provisioned, but makes
+     * determining the current EL simpler and faster. A separate EL for
+     * transmission and reception is not strictly necessary but makes things
+     * easier for interoperation with the handshake layer, which likes to invoke
+     * the yield secret callback at different times for TX and RX.
      */
     unsigned int                    tx_enc_level            : 3;
     unsigned int                    rx_enc_level            : 3;