]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: 74x164: Switch to use dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 7 Feb 2025 15:17:13 +0000 (17:17 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 11 Feb 2025 08:40:03 +0000 (09:40 +0100)
Switch to use dev_err_probe() to simplify the error path and
unify a message template.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250207151825.2122419-7-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-74x164.c

index ecd691de853951c385114d85d251e96997a40190..bbeef03e379703598e5d7da62d5f6a6570c5283c 100644 (file)
@@ -125,10 +125,8 @@ static int gen_74x164_probe(struct spi_device *spi)
                return ret;
 
        ret = device_property_read_u32(&spi->dev, "registers-number", &nregs);
-       if (ret) {
-               dev_err(&spi->dev, "Missing 'registers-number' property.\n");
-               return -EINVAL;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Missing 'registers-number' property.\n");
 
        chip = devm_kzalloc(dev, struct_size(chip, buffer, nregs), GFP_KERNEL);
        if (!chip)