2005-11-22 Hollis Blanchard <hollis@penguinppc.org>

	* term/tparm.c (get_space): Remove empty `if' statement.

	* fs/ufs.c (grub_ufs_find_file): Remove `grub_le_to_cpu32'.

	* kern/parser.c (check_varstate): Rename `state' to 's'.

diff --git a/ChangeLog b/ChangeLog
index 92b9abf1564eb90aac8d46a28b0a5b3dc288a667..173480ccbf8837dd5180b4cb67767737e446bc37 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2005-11-22  Hollis Blanchard  <hollis@penguinppc.org>
+
+       * term/tparm.c (get_space): Remove empty `if' statement.
+
+       * fs/ufs.c (grub_ufs_find_file): Remove `grub_le_to_cpu32'.
+
+       * kern/parser.c (check_varstate): Rename `state' to 's'.
+
 2005-11-22  Hollis Blanchard  <hollis@penguinppc.org>
 
        * partmap/acorn.c: Change `unsigned' to `unsigned int'.  Move all

diff --git a/fs/ufs.c b/fs/ufs.c
index 0215d2c41fc26c90cbdb340d0deadc0faa346984..ab25a67d01e0908ed966f342e07374b50933c1fc 100644 (file)
--- a/fs/ufs.c
+++ b/fs/ufs.c
@@ -471,7 +471,7 @@ grub_ufs_find_file (struct grub_ufs_data *data, const char *path)
       }
       
       pos += grub_le_to_cpu16 (dirent.direntlen);
-    } while (pos < grub_le_to_cpu32 (INODE_SIZE (data)));
+    } while (pos < INODE_SIZE (data));
   
   grub_error (GRUB_ERR_FILE_NOT_FOUND, "file not found");
   return grub_errno;

diff --git a/kern/parser.c b/kern/parser.c
index fe854be4919450e17dfdf186ec68b1509000f5db..abe25c5a955e630e4938398691dcdce816e53d91 100644 (file)
--- a/kern/parser.c
+++ b/kern/parser.c
@@ -115,14 +115,14 @@ grub_parser_split_cmdline (const char *cmdline, grub_err_t (*getline) (char **),
   char *args;
   int i;
 
-  auto int check_varstate (grub_parser_state_t state);
+  auto int check_varstate (grub_parser_state_t s);
 
-  int check_varstate (grub_parser_state_t state)
+  int check_varstate (grub_parser_state_t s)
     {
-      return (state == GRUB_PARSER_STATE_VARNAME
-             || state == GRUB_PARSER_STATE_VARNAME2
-             || state == GRUB_PARSER_STATE_QVARNAME
-             || state == GRUB_PARSER_STATE_QVARNAME2);
+      return (s == GRUB_PARSER_STATE_VARNAME
+             || s == GRUB_PARSER_STATE_VARNAME2
+             || s == GRUB_PARSER_STATE_QVARNAME
+             || s == GRUB_PARSER_STATE_QVARNAME2);
     }
 
   auto void add_var (grub_parser_state_t newstate);

diff --git a/term/tparm.c b/term/tparm.c
index 8272d66fe1b41f5467d7b7aef2b0efb529d4100a..55955b639d817e37c5d91c2fdbbee00dbb1f8037 100644 (file)
--- a/term/tparm.c
+++ b/term/tparm.c
@@ -164,9 +164,7 @@ get_space(grub_size_t need)
     if (need > out_size) {
        out_size = need * 2;
        out_buff = grub_realloc(out_buff, out_size*sizeof(char));
-       if (out_buff == 0)
-           // FIX ME! OOM, what now?
-           ;
+       /* FIX ME! handle out_buff == 0.  */
     }
 }