]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu: Fix golden register init for GFX 12.1.0
authorMukul Joshi <mukul.joshi@amd.com>
Wed, 26 Feb 2025 20:29:09 +0000 (15:29 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 8 Dec 2025 19:12:05 +0000 (14:12 -0500)
TCP_UTCL0 registers are not per XCD so don't init them on a per
XCD basis.

Fixes: ad5f1ee0a9b0 ("drm/amdgpu: Add initial support for gfx v12_1")
Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Reviewed-by: Alex Sierra <alex.sierra@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c

index b2702287536f5dc7e6a3330fb8f32f58e437e89c..a16cd26e9a1b0b42bf8fe10990b1078192ac398d 100644 (file)
@@ -2509,22 +2509,18 @@ static void gfx_v12_1_xcc_disable_gpa_mode(struct amdgpu_device *adev,
 
 static void gfx_v12_1_init_golden_registers(struct amdgpu_device *adev)
 {
-       int i, num_xcc;
        uint32_t val;
 
-       num_xcc = NUM_XCC(adev->gfx.xcc_mask);
-       for (i = 0; i < num_xcc; i++) {
-               /* Setup the TCP Thrashing control register */
-               val = RREG32_SOC15(GC, GET_INST(GC, i), regTCP_UTCL0_THRASHING_CTRL);
+       /* Setup the TCP Thrashing control register */
+       val = RREG32_SOC15(GC, 0, regTCP_UTCL0_THRASHING_CTRL);
 
-               val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL, THRASHING_EN, 0x2);
-               val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL,
-                                       RETRY_FRAGMENT_THRESHOLD_DOWN_EN, 0x0);
-               val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL,
-                                       RETRY_FRAGMENT_THRESHOLD_UP_EN, 0x0);
+       val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL, THRASHING_EN, 0x2);
+       val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL,
+                               RETRY_FRAGMENT_THRESHOLD_DOWN_EN, 0x0);
+       val = REG_SET_FIELD(val, TCP_UTCL0_THRASHING_CTRL,
+                               RETRY_FRAGMENT_THRESHOLD_UP_EN, 0x0);
 
-               WREG32_SOC15(GC, GET_INST(GC, i), regTCP_UTCL0_THRASHING_CTRL, val);
-       }
+       WREG32_SOC15(GC, 0, regTCP_UTCL0_THRASHING_CTRL, val);
 }
 
 static int gfx_v12_1_hw_init(struct amdgpu_ip_block *ip_block)