]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
source: fix resource leak 9907/head
authorPhilippe Antoine <pantoine@oisf.net>
Mon, 27 Nov 2023 12:40:44 +0000 (13:40 +0100)
committerVictor Julien <victor@inliniac.net>
Mon, 27 Nov 2023 21:15:31 +0000 (22:15 +0100)
CID: 1426081

src/source-pcap-file.c

index e54a607d4875582d9d122bcc99881c8787a469e9..c4f97bc0c4c12e0d1e23ae7725f0c30d23a5df77 100644 (file)
@@ -288,6 +288,7 @@ TmEcode ReceivePcapFileThreadInit(ThreadVars *tv, const void *initdata, void **d
         pv->filename = SCStrdup((char*)initdata);
         if (unlikely(pv->filename == NULL)) {
             SCLogError("Failed to allocate filename");
+            closedir(directory);
             CleanupPcapFileDirectoryVars(pv);
             CleanupPcapFileThreadVars(ptv);
             SCReturnInt(TM_ECODE_OK);
@@ -309,6 +310,7 @@ TmEcode ReceivePcapFileThreadInit(ThreadVars *tv, const void *initdata, void **d
         if (pv->should_recurse == true && pv->should_loop == true) {
             SCLogError("Error, --pcap-file-continuous and --pcap-file-recursive "
                        "cannot be used together.");
+            closedir(directory);
             CleanupPcapFileDirectoryVars(pv);
             CleanupPcapFileThreadVars(ptv);
             SCReturnInt(TM_ECODE_FAILED);