Bug 964113: Digest::SHA 5.82 and newer always croak on wide characters, preventing...

r=dkl a=justdave

diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm
index a924324dca529385abc935a488077d9001d98de3..c7e9f645fad768a6ad822647b11919b8eda5fdd9 100644 (file)
--- a/Bugzilla/Token.pm
+++ b/Bugzilla/Token.pm
@@ -171,6 +171,10 @@ sub issue_hash_token {
     my @args = ($time, $user_id, @$data);
 
     my $token = join('*', @args);
+    # Wide characters cause Digest::SHA to die.
+    if (Bugzilla->params->{'utf8'}) {
+        utf8::encode($token) if utf8::is_utf8($token);
+    }
     $token = hmac_sha256_base64($token, Bugzilla->localconfig->{'site_wide_secret'});
     $token =~ s/\+/-/g;
     $token =~ s/\//_/g;

diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl
index b047ffe565cb1672f7e2cc0289555f680e524500..1a10fa81fe74ce28bbcb8f5543305586bfe42f00 100644 (file)
--- a/template/en/default/pages/release-notes.html.tmpl
+++ b/template/en/default/pages/release-notes.html.tmpl
@@ -61,6 +61,9 @@
   <li>An error about <kbd>longdescs.comment_id</kbd> was thrown by MySQL 5.0
     and 5.1 when upgrading to [% terms.Bugzilla %] 4.4 or 4.4.1.
     (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=870369">[% terms.Bug %] 870369</a>)</li>
+  <li>Saved searches containing Unicode characters in their name could not
+    be run if Digest::SHA 5.82 or newer is installed.
+    (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=964113">[% terms.Bug %] 964113</a>)</li>
   <li>A regression in [% terms.Bugzilla %] 4.4.1 caused <kbd>email_in.pl</kbd>
     to fail with an "invalid token" error message.
     (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=928331">[% terms.Bug %] 928331</a> and