exthdr: Simplify tcp option printing a bit

This eliminates the need for that temporary buffer.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/exthdr.c b/src/exthdr.c
index 4add3da24ad8726f7241f0e29d8381fae9111314..37c7688401f601efb79f689f8e47bc7b65abbf9a 100644 (file)
--- a/src/exthdr.c
+++ b/src/exthdr.c
@@ -31,17 +31,13 @@ static void exthdr_expr_print(const struct expr *expr, struct output_ctx *octx)
                 * multiplicator
                 */
                unsigned int offset = expr->exthdr.offset / 64;
-               char buf[9] = {0};
 
-               if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT) {
-                       printf("tcp option %s", expr->exthdr.desc->name);
+               printf("tcp option %s", expr->exthdr.desc->name);
+               if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT)
                        return;
-               }
-
                if (offset)
-                       snprintf(buf, sizeof buf, "%d", offset);
-               printf("tcp option %s%s %s", expr->exthdr.desc->name, buf,
-                                            expr->exthdr.tmpl->token);
+                       printf("%d", offset);
+               printf(" %s", expr->exthdr.tmpl->token);
        } else {
                if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT)
                        printf("exthdr %s", expr->exthdr.desc->name);