Fix bug 64893: ICE with vget_lane_u32 with C++ front-end

2015-02-11  Andrew Pinski  <apinski@cavium.com>

	PR target/64893
	* config/aarch64/aarch64-builtins.c (aarch64_init_simd_builtins):
	Change the first argument type to size_type_node and add another
	size_type_node.
	(aarch64_simd_expand_builtin): Handle the new argument to
	AARCH64_SIMD_BUILTIN_LANE_CHECK and don't ICE but rather
	print an out when the first two arguments are not
	nonzero integer constants.
	* config/aarch64/arm_neon.h (__AARCH64_LANE_CHECK):
	Pass the sizeof directly to __builtin_aarch64_im_lane_boundsi.

2015-02-11  Andrew Pinski  <apinski@cavium.com>

	PR target/64893
	* c-c++-common/torture/aarch64-vect-lane-1.c: New testcase.
	* c-c++-common/torture/aarch64-vect-lane-2.c: New testcase.

From-SVN: r220610

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index be0365d1f17abf9431ef9d0e1aa03a0013b30804..11530bf99358aa9683d3ffc1c20db1dbbd419566 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,16 @@
+2015-02-11  Andrew Pinski  <apinski@cavium.com>
+
+       PR target/64893
+       * config/aarch64/aarch64-builtins.c (aarch64_init_simd_builtins):
+       Change the first argument type to size_type_node and add another
+       size_type_node.
+       (aarch64_simd_expand_builtin): Handle the new argument to
+       AARCH64_SIMD_BUILTIN_LANE_CHECK and don't ICE but rather
+       print an out when the first two arguments are not
+       nonzero integer constants.
+       * config/aarch64/arm_neon.h (__AARCH64_LANE_CHECK):
+       Pass the sizeof directly to __builtin_aarch64_im_lane_boundsi.
+
 2015-02-11  Jakub Jelinek  <jakub@redhat.com>
 
        PR target/61925

diff --git a/gcc/config/aarch64/aarch64-builtins.c b/gcc/config/aarch64/aarch64-builtins.c
index 87f1ac2ec1e3c774782c567b20c673802ae90d99..a9b330591eb6c15fdd90ff475c82d5d56a4d2143 100644 (file)
--- a/gcc/config/aarch64/aarch64-builtins.c
+++ b/gcc/config/aarch64/aarch64-builtins.c
@@ -712,7 +712,8 @@ aarch64_init_simd_builtins (void)
   aarch64_init_simd_builtin_scalar_types ();
  
   tree lane_check_fpr = build_function_type_list (void_type_node,
-                                                 intSI_type_node,
+                                                 size_type_node,
+                                                 size_type_node,
                                                  intSI_type_node,
                                                  NULL);
   aarch64_builtin_decls[AARCH64_SIMD_BUILTIN_LANE_CHECK] =
@@ -1001,13 +1002,23 @@ aarch64_simd_expand_builtin (int fcode, tree exp, rtx target)
 {
   if (fcode == AARCH64_SIMD_BUILTIN_LANE_CHECK)
     {
-      tree nlanes = CALL_EXPR_ARG (exp, 0);
-      gcc_assert (TREE_CODE (nlanes) == INTEGER_CST);
-      rtx lane_idx = expand_normal (CALL_EXPR_ARG (exp, 1));
-      if (CONST_INT_P (lane_idx))
-       aarch64_simd_lane_bounds (lane_idx, 0, TREE_INT_CST_LOW (nlanes), exp);
+      rtx totalsize = expand_normal (CALL_EXPR_ARG (exp, 0));
+      rtx elementsize = expand_normal (CALL_EXPR_ARG (exp, 1));
+      if (CONST_INT_P (totalsize) && CONST_INT_P (elementsize)
+         && UINTVAL (elementsize) != 0
+         && UINTVAL (totalsize) != 0)
+       {
+         rtx lane_idx = expand_normal (CALL_EXPR_ARG (exp, 2));
+          if (CONST_INT_P (lane_idx))
+           aarch64_simd_lane_bounds (lane_idx, 0,
+                                     UINTVAL (totalsize)
+                                      / UINTVAL (elementsize),
+                                     exp);
+          else
+           error ("%Klane index must be a constant immediate", exp);
+       }
       else
-       error ("%Klane index must be a constant immediate", exp);
+       error ("%Ktotal size and element size must be a non-zero constant immediate", exp);
       /* Don't generate any RTL.  */
       return const0_rtx;
     }

diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h
index 2525a27b859db48208f439f4d4a7ef710ee4c598..4c1531222c68792dd88cd9f5c919571ed072f0e9 100644 (file)
--- a/gcc/config/aarch64/arm_neon.h
+++ b/gcc/config/aarch64/arm_neon.h
@@ -541,7 +541,7 @@ typedef struct poly16x8x4_t
 
 #define __AARCH64_NUM_LANES(__v) (sizeof (__v) / sizeof (__v[0]))
 #define __AARCH64_LANE_CHECK(__vec, __idx)     \
-       __builtin_aarch64_im_lane_boundsi (__AARCH64_NUM_LANES (__vec), __idx)
+       __builtin_aarch64_im_lane_boundsi (sizeof(__vec), sizeof(__vec[0]), __idx)
 
 /* For big-endian, GCC's vector indices are the opposite way around
    to the architectural lane indices used by Neon intrinsics.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 1abf3f960f36f4d6d1244a286d296e1f278afc4f..d67d814276055cb145f77994c710b038c8bc381c 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-11  Andrew Pinski  <apinski@cavium.com>
+
+       PR target/64893
+       * c-c++-common/torture/aarch64-vect-lane-1.c: New testcase.
+       * c-c++-common/torture/aarch64-vect-lane-2.c: New testcase.
+
 2015-02-11  Jakub Jelinek  <jakub@redhat.com>
 
        PR target/61925