]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd: fix dcn 2.01 check
authorAndy Nguyen <theofficialflow1996@gmail.com>
Sun, 15 Mar 2026 16:51:47 +0000 (17:51 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Mar 2026 14:40:23 +0000 (10:40 -0400)
The ASICREV_IS_BEIGE_GOBY_P check always took precedence, because it includes all chip revisions upto NV_UNKNOWN.

Fixes: 54b822b3eac3 ("drm/amd/display: Use dce_version instead of chip_id")
Signed-off-by: Andy Nguyen <theofficialflow1996@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c

index e91636d033c7d3b2347fb0e7084b1800a2733231..5a5249f3ffbdae4d7c00720e001d9528cf4a27eb 100644 (file)
@@ -244,6 +244,10 @@ struct clk_mgr *dc_clk_mgr_create(struct dc_context *ctx, struct pp_smu_funcs *p
                        BREAK_TO_DEBUGGER();
                        return NULL;
                }
+               if (ctx->dce_version == DCN_VERSION_2_01) {
+                       dcn201_clk_mgr_construct(ctx, clk_mgr, pp_smu, dccg);
+                       return &clk_mgr->base;
+               }
                if (ASICREV_IS_SIENNA_CICHLID_P(asic_id.hw_internal_rev)) {
                        dcn3_clk_mgr_construct(ctx, clk_mgr, pp_smu, dccg);
                        return &clk_mgr->base;
@@ -256,10 +260,6 @@ struct clk_mgr *dc_clk_mgr_create(struct dc_context *ctx, struct pp_smu_funcs *p
                        dcn3_clk_mgr_construct(ctx, clk_mgr, pp_smu, dccg);
                        return &clk_mgr->base;
                }
-               if (ctx->dce_version == DCN_VERSION_2_01) {
-                       dcn201_clk_mgr_construct(ctx, clk_mgr, pp_smu, dccg);
-                       return &clk_mgr->base;
-               }
                dcn20_clk_mgr_construct(ctx, clk_mgr, pp_smu, dccg);
                return &clk_mgr->base;
        }