]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
timesync: drop meaningless boolean flag
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 25 Feb 2025 04:39:43 +0000 (13:39 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 25 Feb 2025 04:39:46 +0000 (13:39 +0900)
The boolean flag is always true, as manager_save_time_and_rearm() is
called unconditionally.

Follow-up for 33e82f3ef33a2497f9838a5fbb924c7501d8dd9e.

src/timesync/timesyncd-manager.c
src/timesync/timesyncd-manager.h
src/timesync/timesyncd.c

index f453c87864e26ddcd3cf0cb3d55c40696048ecff..087fb7ab3b0a0691910bab61aa781c2a3eeecd3d 100644 (file)
@@ -1219,8 +1219,6 @@ static int manager_save_time_and_rearm(Manager *m, usec_t t) {
         if (r < 0)
                 log_debug_errno(r, "Failed to update "TIMESYNCD_CLOCK_FILE", ignoring: %m");
 
-        m->save_on_exit = true;
-
         return manager_setup_save_time_event(m);
 }
 
index 68fc8f8853aa6049949c770cce95d8af0c2519be..43dbef9417caba9e8198cfe3dd052879c3825cb6 100644 (file)
@@ -112,7 +112,6 @@ struct Manager {
         /* save time event */
         sd_event_source *event_save_time;
         usec_t save_time_interval_usec;
-        bool save_on_exit;
 
         /* Used to coalesce bus PropertiesChanged events */
         sd_event_source *deferred_ntp_server_event_source;
index d002501d29009fb9baa8bb6aa802fc7b17b14fc1..c9628169dca73763de2ad8f650af8078cffef305 100644 (file)
@@ -221,12 +221,10 @@ static int run(int argc, char *argv[]) {
         if (r < 0)
                 return log_error_errno(r, "Failed to run event loop: %m");
 
-        /* if we got an authoritative time, store it in the file system */
-        if (m->save_on_exit) {
-                r = touch(TIMESYNCD_CLOCK_FILE);
-                if (r < 0)
-                        log_debug_errno(r, "Failed to touch "TIMESYNCD_CLOCK_FILE", ignoring: %m");
-        }
+        /* Save the current time in the file system on exit. */
+        r = touch(TIMESYNCD_CLOCK_FILE);
+        if (r < 0)
+                log_debug_errno(r, "Failed to touch "TIMESYNCD_CLOCK_FILE", ignoring: %m");
 
         return 0;
 }