]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
mkfs.cramfs: use defined failure name rather than magic value
authorSami Kerola <kerolasa@iki.fi>
Sun, 13 Jul 2014 16:36:33 +0000 (17:36 +0100)
committerSami Kerola <kerolasa@iki.fi>
Sun, 13 Jul 2014 17:35:32 +0000 (18:35 +0100)
From manual page; 'On error, the value MAP_FAILED is returned, and errno
is set appropriately'.

Reference: http://man7.org/linux/man-pages/man2/mmap.2.html
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
disk-utils/mkfs.cramfs.c

index 6f412d888189fa4f746e810b7080e528d4a732fe..bae68ecb3706c1a33ce1b551b252fc99b2773b3f 100644 (file)
@@ -167,11 +167,9 @@ do_mmap(char *path, unsigned int size, unsigned int mode){
        }
 
        start = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0);
-       if (-1 == (int) (long) start) {
-               close(fd);
-               err(MKFS_EX_ERROR, "mmap");
-       }
        close(fd);
+       if (start == MAP_FAILED)
+               err(MKFS_EX_ERROR, "mmap");
        return start;
 err:
        free(start);