r19261: Fix use of unitialised variables. (The binding string is used, if not

NULL).

This showed up in a manual pre-TP3 test of the 'net samdump' code, and
shows the critical need for the windows testing infrustructure on the
build farm.

Andrew Bartlett
(This used to be commit 9cef40779ad987b506b1f514a67b5b1c8aea9969)

diff --git a/source4/libnet/libnet_join.c b/source4/libnet/libnet_join.c
index 14e3e5b719d8ea2ea163ce5cec41ca2a11e7e5b0..5781bc19c28ebc3765572a080b3ce20c20175fc0 100644 (file)
--- a/source4/libnet/libnet_join.c
+++ b/source4/libnet/libnet_join.c
@@ -460,9 +460,11 @@ NTSTATUS libnet_JoinDomain(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, stru
 
        /* prepare connect to the LSA pipe of PDC */
        if (r->in.level == LIBNET_JOINDOMAIN_AUTOMATIC) {
+               connect_with_info->in.binding = NULL;
                connect_with_info->in.name    = r->in.domain_name;
        } else {
                connect_with_info->in.binding = r->in.binding;
+               connect_with_info->in.name    = NULL;
        }
 
        connect_with_info->level              = LIBNET_RPC_CONNECT_DC_INFO;

diff --git a/source4/libnet/libnet_vampire.c b/source4/libnet/libnet_vampire.c
index 7421f8943c5f688fbba90662ec50eba58d65aa11..f5a326c676df1402d51e20da13f28bde9ba6cffd 100644 (file)
--- a/source4/libnet/libnet_vampire.c
+++ b/source4/libnet/libnet_vampire.c
@@ -202,8 +202,9 @@ NTSTATUS libnet_SamSync_netlogon(struct libnet_context *ctx, TALLOC_CTX *mem_ctx
        c->level              = LIBNET_RPC_CONNECT_DC_INFO;
        if (r->in.binding_string) {
                c->in.binding = r->in.binding_string;
-
+               c->in.name    = NULL;
        } else {
+               c->in.binding = NULL;
                c->in.name    = cli_credentials_get_domain(machine_account);
        }