]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
network: use __instantiate_ns_common() in instantiate_ns_phys() too 3419/head
authorChristian Brauner <christian.brauner@ubuntu.com>
Tue, 19 May 2020 07:09:24 +0000 (09:09 +0200)
committerChristian Brauner <christian.brauner@ubuntu.com>
Tue, 19 May 2020 07:09:40 +0000 (09:09 +0200)
Fixes: https://lists.linuxcontainers.org/pipermail/lxc-users/2020-May/015245.html
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
src/lxc/network.c

index 5845a5c13f0867728b6b69785beeb29afbdfa648..da09141dd6d2506ee8d09020443cc0cd1aa0c7a4 100644 (file)
@@ -860,7 +860,7 @@ static  instantiate_cb netdev_conf[LXC_NET_MAXCONFTYPE + 1] = {
        [LXC_NET_NONE]    = instantiate_none,
 };
 
-static int __instantiate_common(struct lxc_netdev *netdev)
+static int __instantiate_ns_common(struct lxc_netdev *netdev)
 {
        char current_ifname[IFNAMSIZ];
 
@@ -905,33 +905,27 @@ static int __instantiate_common(struct lxc_netdev *netdev)
 static int instantiate_ns_veth(struct lxc_netdev *netdev)
 {
 
-       return __instantiate_common(netdev);
+       return __instantiate_ns_common(netdev);
 }
 
 static int instantiate_ns_macvlan(struct lxc_netdev *netdev)
 {
-       return __instantiate_common(netdev);
+       return __instantiate_ns_common(netdev);
 }
 
 static int instantiate_ns_ipvlan(struct lxc_netdev *netdev)
 {
-       return __instantiate_common(netdev);
+       return __instantiate_ns_common(netdev);
 }
 
 static int instantiate_ns_vlan(struct lxc_netdev *netdev)
 {
-       return __instantiate_common(netdev);
+       return __instantiate_ns_common(netdev);
 }
 
 static int instantiate_ns_phys(struct lxc_netdev *netdev)
 {
-       netdev->ifindex = if_nametoindex(netdev->name);
-       if (!netdev->ifindex)
-               return log_error_errno(-1, errno,
-                                      "Failed to retrieve ifindex for network device with name %s",
-                                      netdev->name);
-
-       return 0;
+       return __instantiate_ns_common(netdev);
 }
 
 static int instantiate_ns_empty(struct lxc_netdev *netdev)