]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: rockchip: samsung-hdptx: Add high color depth management
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tue, 18 Mar 2025 12:35:48 +0000 (14:35 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Apr 2025 11:48:04 +0000 (17:18 +0530)
Add support for 8-bit, 10-bit, 12-bit and 16-bit color depth setup.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Dmitry Baryshkov <dmtiry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250318-phy-sam-hdptx-bpc-v6-14-8cb1678e7663@collabora.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

index d09e1f7b25ec131d3c40fb52564cad27dce3b2d4..fc289ed8d915d84916870329101655cd956898e3 100644 (file)
@@ -1028,6 +1028,9 @@ static int rk_hdptx_ropll_tmds_cmn_config(struct rk_hdptx_phy *hdptx)
        regmap_update_bits(hdptx->regmap, CMN_REG(0086), PLL_PCG_POSTDIV_SEL_MASK,
                           FIELD_PREP(PLL_PCG_POSTDIV_SEL_MASK, cfg->pms_sdiv));
 
+       regmap_update_bits(hdptx->regmap, CMN_REG(0086), PLL_PCG_CLK_SEL_MASK,
+                          FIELD_PREP(PLL_PCG_CLK_SEL_MASK, (hdptx->hdmi_cfg.bpc - 8) >> 1));
+
        regmap_update_bits(hdptx->regmap, CMN_REG(0086), PLL_PCG_CLK_EN_MASK,
                           FIELD_PREP(PLL_PCG_CLK_EN_MASK, 0x1));
 
@@ -1427,7 +1430,8 @@ static int rk_hdptx_phy_power_on(struct phy *phy)
                        hdptx->hdmi_cfg.tmds_char_rate *= 100;
                }
 
-               dev_dbg(hdptx->dev, "%s rate=%llu\n", __func__, hdptx->hdmi_cfg.tmds_char_rate);
+               dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__,
+                       hdptx->hdmi_cfg.tmds_char_rate, hdptx->hdmi_cfg.bpc);
        }
 
        ret = rk_hdptx_phy_consumer_get(hdptx);
@@ -1492,6 +1496,19 @@ static int rk_hdptx_phy_verify_hdmi_config(struct rk_hdptx_phy *hdptx,
            !rk_hdptx_phy_clk_pll_calc(hdmi->tmds_char_rate, NULL))
                return -EINVAL;
 
+       if (!hdmi->bpc)
+               hdmi->bpc = 8;
+
+       switch (hdmi->bpc) {
+       case 8:
+       case 10:
+       case 12:
+       case 16:
+               break;
+       default:
+               return -EINVAL;
+       };
+
        return 0;
 }
 
@@ -1764,6 +1781,9 @@ static int rk_hdptx_phy_configure(struct phy *phy, union phy_configure_opts *opt
                        hdptx->hdmi_cfg = opts->hdmi;
                        hdptx->restrict_rate_change = true;
                }
+
+               dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__,
+                       hdptx->hdmi_cfg.tmds_char_rate, hdptx->hdmi_cfg.bpc);
                return ret;
        }
 
@@ -1972,6 +1992,7 @@ static int rk_hdptx_phy_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        hdptx->dev = dev;
+       hdptx->hdmi_cfg.bpc = 8;
 
        regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(regs))