]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
fortran: Fix invalid function decl clobber ICE [PR105012]
authorMikael Morin <mikael@gcc.gnu.org>
Mon, 29 Aug 2022 09:19:29 +0000 (11:19 +0200)
committerMikael Morin <mikael@gcc.gnu.org>
Mon, 10 Oct 2022 20:06:48 +0000 (22:06 +0200)
The fortran frontend, as result symbol for a function without
declared result symbol, uses the function symbol itself.  This caused
an invalid clobber of a function decl to be emitted, leading to an
ICE, whereas the intended behaviour was to clobber the function result
variable.  This change fixes the problem by getting the decl from the
just-retrieved variable reference after the call to
gfc_conv_expr_reference, instead of copying it from the frontend symbol.

PR fortran/105012

gcc/fortran/ChangeLog:

* trans-expr.c (gfc_conv_procedure_call): Retrieve variable
from the just calculated variable reference.

gcc/testsuite/ChangeLog:

* gfortran.dg/intent_out_15.f90: New test.

(cherry picked from commit edaf1e005c90b311c39b46d85cea17befbece112)

gcc/fortran/trans-expr.c
gcc/testsuite/gfortran.dg/intent_out_15.f90 [new file with mode: 0644]

index 2592c280a3c027e4f64e253808b4c1ea86777bbd..6823379e41a58d58f2910c2f7106e65f8c74aa02 100644 (file)
@@ -6104,7 +6104,8 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
                          tree var;
                          /* FIXME: This fails if var is passed by reference, see PR
                             41453.  */
-                         var = e->symtree->n.sym->backend_decl;
+                         var = build_fold_indirect_ref_loc (input_location,
+                                                            parmse.expr);
                          tree clobber = build_clobber (TREE_TYPE (var));
                          gfc_add_modify (&se->pre, var, clobber);
                        }
diff --git a/gcc/testsuite/gfortran.dg/intent_out_15.f90 b/gcc/testsuite/gfortran.dg/intent_out_15.f90
new file mode 100644 (file)
index 0000000..64334e6
--- /dev/null
@@ -0,0 +1,27 @@
+! { dg-do compile }
+! { dg-additional-options "-fdump-tree-original" }
+!
+! PR fortran/105012
+! The following case was triggering an ICE because of a clobber
+! on the DERFC function decl instead of its result.
+
+module error_function
+integer, parameter :: r8 = selected_real_kind(12) ! 8 byte real
+contains
+SUBROUTINE CALERF_r8(ARG, RESULT, JINT)
+   integer, parameter :: rk = r8
+   real(rk), intent(in)  :: arg
+   real(rk), intent(out) :: result
+   IF (Y .LE. THRESH) THEN
+   END IF
+end SUBROUTINE CALERF_r8
+FUNCTION DERFC(X)
+   integer, parameter :: rk = r8 ! 8 byte real
+   real(rk), intent(in) :: X
+   real(rk) :: DERFC
+   CALL CALERF_r8(X, DERFC, JINT)
+END FUNCTION DERFC
+end module error_function
+
+! { dg-final { scan-tree-dump-times "CLOBBER" 1 "original" } }
+! { dg-final { scan-tree-dump "__result_derfc = {CLOBBER};" "original" } }