]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
lscpu: fix cpu map array sizes
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Wed, 10 Aug 2011 08:34:28 +0000 (10:34 +0200)
committerHeiko Carstens <heiko.carstens@de.ibm.com>
Sun, 14 Aug 2011 15:34:12 +0000 (17:34 +0200)
Completely virtualized architectures like s390 may have multiple
virtual sockets and/or cores where each of them has a different
number of cores and cpus.
So the general assumption within the allocation scheme that e.g.
each socket contains the same number of cores is not necessarily
true. To make sure the arrays are always large enough we simply
allocate enough memory so that each array could hold cpu masks
for all present cpus.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
sys-utils/lscpu.c

index 48c8044d445e46ab97c2917195042a13523c100c..4eeb502e1ccb37eee362a41e28072900b17a7ea8 100644 (file)
@@ -660,11 +660,16 @@ read_topology(struct lscpu_desc *desc, int num)
                 */
                if (!desc->nthreads)
                        desc->nthreads = nsockets * ncores * nthreads;
+               /* For each map we make sure that it can have up to ncpus
+                * entries. This is because we cannot reliably calculate the
+                * number of cores, sockets and books on all architectures.
+                * E.g. completely virtualized architectures like s390 may
+                * have multiple sockets of different sizes.
+                */
+               desc->coremaps = xcalloc(desc->ncpus, sizeof(cpu_set_t *));
+               desc->socketmaps = xcalloc(desc->ncpus, sizeof(cpu_set_t *));
                if (book_siblings)
-                       desc->bookmaps = xcalloc(nbooks, sizeof(cpu_set_t *));
-
-               desc->socketmaps = xcalloc(nsockets, sizeof(cpu_set_t *));
-               desc->coremaps = xcalloc(ncores * nsockets, sizeof(cpu_set_t *));
+                       desc->bookmaps = xcalloc(desc->ncpus, sizeof(cpu_set_t *));
        }
 
        add_cpuset_to_array(desc->socketmaps, &desc->nsockets, core_siblings);