]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI/portdrv: Don't check for valid device and driver in bus callbacks
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Tue, 2 Dec 2025 15:13:53 +0000 (16:13 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 13 Jan 2026 21:48:59 +0000 (15:48 -0600)
The driver core ensures that in .probe() and .remove() both dev and
dev->driver are valid. So drop the respective check.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Link: https://patch.msgid.link/2cc2e15e05318b9f0d7b6a2b69b3169d2a6f0bd3.1764688034.git.u.kleine-koenig@baylibre.com
drivers/pci/pcie/portdrv.c

index 0127e3dc768f4d87d814bd514f5cf67df3979858..7bd48c5da133fd79752da07ca80c577c9c0842ae 100644 (file)
@@ -537,9 +537,6 @@ static int pcie_port_probe_service(struct device *dev)
        struct pcie_port_service_driver *driver;
        int status;
 
-       if (!dev || !dev->driver)
-               return -ENODEV;
-
        driver = to_service_driver(dev->driver);
        if (!driver || !driver->probe)
                return -ENODEV;
@@ -567,9 +564,6 @@ static int pcie_port_remove_service(struct device *dev)
        struct pcie_device *pciedev;
        struct pcie_port_service_driver *driver;
 
-       if (!dev || !dev->driver)
-               return 0;
-
        pciedev = to_pcie_device(dev);
        driver = to_service_driver(dev->driver);
        if (driver && driver->remove)