Remove useless range check.

diff --git a/dhcpcd.c b/dhcpcd.c
index 0c9859428365aeee2e5a81595a09fef3167dc80c..09a5dd0335c4e2c32324472bd1eb511433bcd64e 100644 (file)
--- a/dhcpcd.c
+++ b/dhcpcd.c
@@ -1455,6 +1455,12 @@ main(int argc, char **argv)
        const char *siga = NULL;
 #endif
 
+       int seq;
+       seq = INT_MAX;
+       printf ("%d\n", seq);
+       seq++;
+       printf ("%u\n", (uint32_t)seq);
+
        /* Test for --help and --version */
        if (argc > 1) {
                if (strcmp(argv[1], "--help") == 0) {

diff --git a/dhcpcd.h b/dhcpcd.h
index a5b8cf45b088c2aec4e18fa57aa230c4310b5440..08c7723b5c292ed435826ecd58ac4629bf4b435c 100644 (file)
--- a/dhcpcd.h
+++ b/dhcpcd.h
@@ -122,8 +122,8 @@ struct dhcpcd_ctx {
 #endif
        void *priv;
        int link_fd;
-       unsigned int seq;       /* route message sequence no */
-       unsigned int sseq;      /* successful seq no sent */
+       int seq;        /* route message sequence no */
+       int sseq;       /* successful seq no sent */
 
 #ifdef USE_SIGNALS
        sigset_t sigset;

diff --git a/if-linux.c b/if-linux.c
index 3898635f6a957f597967fb026b01ba485926f67b..d646d003b7c751b663f1012853540544efbf13ad 100644 (file)
--- a/if-linux.c
+++ b/if-linux.c
@@ -925,9 +925,7 @@ send_netlink(struct dhcpcd_ctx *ctx, struct interface *ifp,
        msg.msg_iovlen = 1;
        /* Request a reply */
        hdr->nlmsg_flags |= NLM_F_ACK;
-       if (++ctx->seq > UINT32_MAX)
-               ctx->seq = 0;
-       hdr->nlmsg_seq = (uint32_t)ctx->seq;
+       hdr->nlmsg_seq = (uint32_t)++ctx->seq;
        if (sendmsg(s, &msg, 0) != -1) {
                ctx->sseq = ctx->seq;
                r = get_netlink(ctx, ifp, s, 0, callback);