]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: mediatek: mt8189: remove unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 26 Nov 2025 14:52:26 +0000 (17:52 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 26 Nov 2025 17:41:27 +0000 (17:41 +0000)
Smatch complains that the call to snd_soc_component_get_drvdata(component)
will dereference "component" so this NULL check is too late.  The probe()
function will never be called with a NULL component pointer so just
delete the check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aScUKqCEhSIZoOmg@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8189/mt8189-afe-pcm.c

index dcee8e11eca86ad908a78540bb8df20e1e61e235..166ece74270ece0f6f488fe4b25c92a47c1db95a 100644 (file)
@@ -2352,12 +2352,10 @@ static int mt8189_afe_component_probe(struct snd_soc_component *component)
 {
        struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
 
-       if (component) {
-               /* enable clock for regcache get default value from hw */
-               pm_runtime_get_sync(afe->dev);
-               mtk_afe_add_sub_dai_control(component);
-               pm_runtime_put_sync(afe->dev);
-       }
+       /* enable clock for regcache get default value from hw */
+       pm_runtime_get_sync(afe->dev);
+       mtk_afe_add_sub_dai_control(component);
+       pm_runtime_put_sync(afe->dev);
 
        return 0;
 }