Bug 607361: Creating an attachment without a "comment" param in the URL causes an...

a=LpSolit

diff --git a/attachment.cgi b/attachment.cgi
index 789b55fb46e23f5570beb6708d30a8136f088f4d..d1836ca92bd7b93f794ea1a35b52f58fd56b9ea9 100755 (executable)
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -501,6 +501,7 @@ sub insert {
 
     # Insert a comment about the new attachment into the database.
     my $comment = $cgi->param('comment');
+    $comment = '' unless defined $comment;
     $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                   type => CMT_ATTACHMENT_CREATED,
                                   extra_data => $attachment->id });
@@ -636,7 +637,7 @@ sub update {
     # If the user submitted a comment while editing the attachment,
     # add the comment to the bug. Do this after having validated isprivate!
     my $comment = $cgi->param('comment');
-    if (trim($comment)) {
+    if (defined $comment && trim($comment) ne '') {
         $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                       type => CMT_ATTACHMENT_UPDATED,
                                       extra_data => $attachment->id });