]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: domain: Don't leak device alias list
authorPeter Krempa <pkrempa@redhat.com>
Tue, 24 Mar 2015 13:52:11 +0000 (14:52 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 25 Mar 2015 12:27:22 +0000 (13:27 +0100)
While adding tests for status XML parsing and formatting I've noticed
that the device alias list is leaked.

==763001== 81 (48 direct, 33 indirect) bytes in 1 blocks are definitely lost in loss record 414 of 514
==763001==    at 0x4C2B8F0: calloc (vg_replace_malloc.c:623)
==763001==    by 0x6ACF70F: virAllocN (viralloc.c:191)
==763001==    by 0x447B64: qemuDomainObjPrivateXMLParse (qemu_domain.c:727)
==763001==    by 0x6B848F9: virDomainObjParseXML (domain_conf.c:15491)
==763001==    by 0x6B84CAC: virDomainObjParseNode (domain_conf.c:15608)

src/qemu/qemu_domain.c

index 4838926300ed240f62e2009fe882dbe974a6dd74..758fcd9d27d66d230eec22b784b2a3c66e97243d 100644 (file)
@@ -444,6 +444,7 @@ qemuDomainObjPrivateFree(void *data)
     VIR_FREE(priv->origname);
 
     virCondDestroy(&priv->unplugFinished);
+    virStringFreeList(priv->qemuDevices);
     virChrdevFree(priv->devs);
 
     /* This should never be non-NULL if we get here, but just in case... */