]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/damon/tests/core-kunit: handle memory failure from damon_test_target()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:19:57 +0000 (11:19 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:48 +0000 (10:14 +0100)
commit fafe953de2c661907c94055a2497c6b8dbfd26f3 upstream.

damon_test_target() is assuming all dynamic memory allocation in it will
succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-4-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/tests/core-kunit.h

index 27816e57d0d5a947321f92a41be045927a5e2695..0fe5bb5808f2f09d60e04d252121b5be81429afc 100644 (file)
@@ -58,7 +58,14 @@ static void damon_test_target(struct kunit *test)
        struct damon_ctx *c = damon_new_ctx();
        struct damon_target *t;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
+
        t = damon_new_target();
+       if (!t) {
+               damon_destroy_ctx(c);
+               kunit_skip(test, "target alloc fail");
+       }
        KUNIT_EXPECT_EQ(test, 0u, nr_damon_targets(c));
 
        damon_add_target(c, t);