]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: max77759: drop use of irqd_get_trigger_type
authorAndré Draszik <andre.draszik@linaro.org>
Wed, 17 Dec 2025 11:45:06 +0000 (11:45 +0000)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Fri, 2 Jan 2026 10:01:13 +0000 (11:01 +0100)
irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.

Drop the use from this driver, as it doesn't need to know the trigger
type.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20251217-max77759-gpio-irq-trigger-v1-1-5738953c1172@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-max77759.c

index 5e48eb03e7b366465e24383a7d1152351906968a..3bf9f23d1532848d8706f7291f59b5c20e9715a4 100644 (file)
@@ -435,8 +435,6 @@ static int max77759_gpio_probe(struct platform_device *pdev)
        int irq;
        struct gpio_irq_chip *girq;
        int ret;
-       unsigned long irq_flags;
-       struct irq_data *irqd;
 
        chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)
@@ -486,13 +484,9 @@ static int max77759_gpio_probe(struct platform_device *pdev)
                return dev_err_probe(&pdev->dev, ret,
                                     "Failed to add GPIO chip\n");
 
-       irq_flags = IRQF_ONESHOT | IRQF_SHARED;
-       irqd = irq_get_irq_data(irq);
-       if (irqd)
-               irq_flags |= irqd_get_trigger_type(irqd);
-
        ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-                                       max77759_gpio_irqhandler, irq_flags,
+                                       max77759_gpio_irqhandler,
+                                       IRQF_ONESHOT | IRQF_SHARED,
                                        dev_name(&pdev->dev), chip);
        if (ret < 0)
                return dev_err_probe(&pdev->dev, ret,