]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests/bpf: Use memcpy() for bounded non-NULL-terminated copies
authorIhor Solodrai <ihor.solodrai@linux.dev>
Mon, 23 Feb 2026 19:07:21 +0000 (11:07 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 24 Feb 2026 16:19:49 +0000 (08:19 -0800)
Replace strncpy() with memcpy() in cases where the source is
non-NULL-terminated and the copy length is known.

Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Link: https://lore.kernel.org/r/20260223190736.649171-6-ihor.solodrai@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/prog_tests/ctx_rewrite.c
tools/testing/selftests/bpf/test_verifier.c

index dd75ccb03770c5fe3853051207d8ffb94c19fdad..469e92869523fa7b22ca78786bb09aa7677b5c00 100644 (file)
@@ -308,8 +308,10 @@ static int find_field_offset(struct btf *btf, char *pattern, regmatch_t *matches
                return -1;
        }
 
-       strncpy(type_str, type, type_sz);
-       strncpy(field_str, field, field_sz);
+       memcpy(type_str, type, type_sz);
+       type_str[type_sz] = '\0';
+       memcpy(field_str, field, field_sz);
+       field_str[field_sz] = '\0';
        btf_id = btf__find_by_name(btf, type_str);
        if (btf_id < 0) {
                PRINT_FAIL("No BTF info for type %s\n", type_str);
index 27db34ecf3f5c880cb66087cc8e05ecdb0af4824..a8ae03c57bbaeea24f6b0bae2d6fd10cd5c0b9a6 100644 (file)
@@ -1320,7 +1320,7 @@ static bool cmp_str_seq(const char *log, const char *exp)
                        printf("FAIL\nTestcase bug\n");
                        return false;
                }
-               strncpy(needle, exp, len);
+               memcpy(needle, exp, len);
                needle[len] = 0;
                q = strstr(log, needle);
                if (!q) {