]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86: Set default non_temporal_threshold for Zhaoxin processors
authorMayShao-oc <MayShao-oc@zhaoxin.com>
Sat, 29 Jun 2024 03:58:28 +0000 (11:58 +0800)
committerH.J. Lu <hjl.tools@gmail.com>
Sun, 30 Jun 2024 13:26:43 +0000 (06:26 -0700)
Current 'non_temporal_threshold' set to 'non_temporal_threshold_lowbound'
on Zhaoxin processors without ERMS. The default
'non_temporal_threshold_lowbound' is too small for the KH-40000 and KX-7000
Zhaoxin processors, this patch updates the value to
'shared / cachesize_non_temporal_divisor'.
Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
sysdeps/x86/cpu-features.c
sysdeps/x86/dl-cacheinfo.h

index 1927f65699957f6762a44e4cfe8c5b64f771a103..e501e084ef40380db341dc1c9a4093d81af4719e 100644 (file)
@@ -1065,6 +1065,7 @@ https://www.intel.com/content/www/us/en/support/articles/000059422/processors.ht
 
              /* Yongfeng and Shijidadao mircoarch tuning.  */
            case 0x5b:
+             cpu_features->cachesize_non_temporal_divisor = 2;
            case 0x6b:
              cpu_features->preferred[index_arch_AVX_Fast_Unaligned_Load]
                  &= ~bit_arch_AVX_Fast_Unaligned_Load;
index 3a6ec4ef9f787e2fc439702985af9cafd1988640..5e77345a6e3998833ba7b2fbbb1c18ee78a902a1 100644 (file)
@@ -934,8 +934,10 @@ dl_init_cacheinfo (struct cpu_features *cpu_features)
   /* If no ERMS, we use the per-thread L3 chunking. Normal cacheable stores run
      a higher risk of actually thrashing the cache as they don't have a HW LRU
      hint. As well, their performance in highly parallel situations is
-     noticeably worse.  */
-  if (!CPU_FEATURE_USABLE_P (cpu_features, ERMS))
+     noticeably worse. Zhaoxin processors are an exception, the lowbound is not
+     suitable for them based on actual test data.  */
+  if (!CPU_FEATURE_USABLE_P (cpu_features, ERMS)
+      && cpu_features->basic.kind != arch_kind_zhaoxin)
     non_temporal_threshold = non_temporal_threshold_lowbound;
   /* SIZE_MAX >> 4 because memmove-vec-unaligned-erms right-shifts the value of
      'x86_non_temporal_threshold' by `LOG_4X_MEMCPY_THRESH` (4) and it is best