]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
watchdog: starfive: Add missing clk_disable_unprepare()
authorChen Ni <nichen@iscas.ac.cn>
Fri, 28 Jun 2024 03:35:08 +0000 (11:35 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Wed, 10 Jul 2024 18:01:30 +0000 (20:01 +0200)
Add the missing clk_disable_unprepare() before return in
starfive_wdt_enable_clock().

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Xingyu Wu <xingyu.wu@starfivetech.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20240628033508.281058-1-nichen@iscas.ac.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/starfive-wdt.c

index b4b059883618b94e8b8d77d9170b5f8cd71c7419..19a2620d3d3893db1f57db78d230f94bc385db22 100644 (file)
@@ -152,8 +152,10 @@ static int starfive_wdt_enable_clock(struct starfive_wdt *wdt)
                return dev_err_probe(wdt->wdd.parent, ret, "failed to enable apb clock\n");
 
        ret = clk_prepare_enable(wdt->core_clk);
-       if (ret)
+       if (ret) {
+               clk_disable_unprepare(wdt->apb_clk);
                return dev_err_probe(wdt->wdd.parent, ret, "failed to enable core clock\n");
+       }
 
        return 0;
 }