]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: es8323: remove DAC enablement write from es8323_set_bias_level
authorBinbin Zhou <zhoubinbin@loongson.cn>
Sat, 17 Jan 2026 09:18:35 +0000 (17:18 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 19 Jan 2026 14:42:14 +0000 (14:42 +0000)
Since commit daf855f76a12 ("ASoC: es8323: enable DAPM power widgets for
playback DAC"), the DAC is handled by the DAPM subsystem.

Remove initialization of the DAC enablement bits from the
es8323_set_bias_level routine

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/d2823ad7ae226a83d49bcb860240c0ddc4080f14.1768641428.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/es8323.c

index 8647ddc1c28530e24ec6cbdc83020a99b6f36579..4a589949cc7e5ce8785a58acb567fb8f16a118d9 100644 (file)
@@ -576,8 +576,6 @@ static int es8323_pcm_hw_params(struct snd_pcm_substream *substream,
        snd_soc_component_write_field(component, ES8323_DACCONTROL1,
                                      ES8323_DACCONTROL1_DACWL, wl_mode);
 
-       snd_soc_component_write(component, ES8323_DACPOWER, 0x3c);
-
        return 0;
 }
 
@@ -659,7 +657,6 @@ static int es8323_set_bias_level(struct snd_soc_component *component,
 
                snd_soc_component_write(component, ES8323_CHIPPOWER, 0xf0);
                usleep_range(18000, 20000);
-               snd_soc_component_write(component, ES8323_DACPOWER, 0x3c);
                snd_soc_component_write(component, ES8323_ANAVOLMANAG, 0x7c);
                snd_soc_component_write(component, ES8323_CHIPLOPOW1, 0x00);
                snd_soc_component_write(component, ES8323_CHIPLOPOW2, 0x00);
@@ -679,7 +676,6 @@ static int es8323_set_bias_level(struct snd_soc_component *component,
        case SND_SOC_BIAS_OFF:
                clk_disable_unprepare(es8323->mclk);
                snd_soc_component_write(component, ES8323_ADCPOWER, 0xff);
-               snd_soc_component_write(component, ES8323_DACPOWER, 0xC0);
                snd_soc_component_write(component, ES8323_CHIPLOPOW1, 0xff);
                snd_soc_component_write(component, ES8323_CHIPLOPOW2, 0xff);
                snd_soc_component_write(component, ES8323_CHIPPOWER, 0xff);