]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: dvb-usb-v2: lmedm04: Fix firmware macro definitions
authorKees Cook <kees@kernel.org>
Fri, 10 Oct 2025 03:06:07 +0000 (20:06 -0700)
committerDaniel Gomez <da.gomez@samsung.com>
Wed, 5 Nov 2025 13:08:55 +0000 (14:08 +0100)
The firmware filename macros incorrectly included semicolons in their
string literal definitions. Right now, this wasn't causing any real
problem, but coming changes to the MODULE_INFO() macro make this more
sensitive. Specifically, when used with MODULE_FIRMWARE(), this
created syntax errors during macro expansion:

    MODULE_FIRMWARE(LME2510_C_S7395);

expands to:

    MODULE_INFO(firmware, "dvb-usb-lme2510c-s7395.fw";)
                                                     ^
                                          syntax error

Remove the trailing semicolons from all six firmware filename macro
definitions. Semicolons should only appear at the point of use, not in
the macro definition.

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Tested-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
drivers/media/usb/dvb-usb-v2/lmedm04.c

index 0c510035805b4dc019d85572fee51a22195350cc..05c18b6de5c6d95a2fc9343d9413be725287a03b 100644 (file)
 #include "ts2020.h"
 
 
-#define LME2510_C_S7395        "dvb-usb-lme2510c-s7395.fw";
-#define LME2510_C_LG   "dvb-usb-lme2510c-lg.fw";
-#define LME2510_C_S0194        "dvb-usb-lme2510c-s0194.fw";
-#define LME2510_C_RS2000 "dvb-usb-lme2510c-rs2000.fw";
-#define LME2510_LG     "dvb-usb-lme2510-lg.fw";
-#define LME2510_S0194  "dvb-usb-lme2510-s0194.fw";
+#define LME2510_C_S7395        "dvb-usb-lme2510c-s7395.fw"
+#define LME2510_C_LG   "dvb-usb-lme2510c-lg.fw"
+#define LME2510_C_S0194        "dvb-usb-lme2510c-s0194.fw"
+#define LME2510_C_RS2000 "dvb-usb-lme2510c-rs2000.fw"
+#define LME2510_LG     "dvb-usb-lme2510-lg.fw"
+#define LME2510_S0194  "dvb-usb-lme2510-s0194.fw"
 
 /* debug */
 static int dvb_usb_lme2510_debug;