block: rnbd-clt: Fix signedness bug in init_dev()

[ Upstream commit 1ddb815fdfd45613c32e9bd1f7137428f298e541 ]

The "dev->clt_device_id" variable is set using ida_alloc_max() which
returns an int and in particular it returns negative error codes.
Change the type from u32 to int to fix the error checking.

Fixes: c9b5645fd8ca ("block: rnbd-clt: Fix leaked ID in init_dev()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/block/rnbd/rnbd-clt.h b/drivers/block/rnbd/rnbd-clt.h
index 2941e3862b9c3e0f5693ae36ce91bca7c430ffa1..beda2d6ce91097d5d08ec1255db691c3d3bfed64 100644 (file)
--- a/drivers/block/rnbd/rnbd-clt.h
+++ b/drivers/block/rnbd/rnbd-clt.h
@@ -105,7 +105,7 @@ struct rnbd_clt_dev {
        struct rnbd_queue       *hw_queues;
        u32                     device_id;
        /* local Idr index - used to track minor number allocations. */
-       u32                     clt_device_id;
+       int                     clt_device_id;
        struct mutex            lock;
        enum rnbd_clt_dev_state dev_state;
        char                    *pathname;