]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libmount, col: remove redundant null checks [smatch scan]
authorSami Kerola <kerolasa@iki.fi>
Mon, 8 Apr 2013 19:32:51 +0000 (20:32 +0100)
committerKarel Zak <kzak@redhat.com>
Tue, 9 Apr 2013 10:26:42 +0000 (12:26 +0200)
libmount/src/context_umount.c:174 mnt_context_find_umount_fs() info: redundant null check on loopdev calling free()
libmount/src/context_umount.c:179 mnt_context_find_umount_fs() info: redundant null check on loopdev calling free()
text-utils/col.c:406 flush_lines() info: redundant null check on l->l_line calling free()

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
libmount/src/context_umount.c
text-utils/col.c

index 96ae87ae16c5030cca76dad79260096562824499..b9484594bf8bada2b873d782f989e59f2f6b3cff 100644 (file)
@@ -170,13 +170,11 @@ try_loopdev:
        }
 
        *pfs = fs;
-       if (loopdev)
-               free(loopdev);
+       free(loopdev);
 
        return fs ? 0 : 1;
 err:
-       if (loopdev)
-               free(loopdev);
+       free(loopdev);
        return rc;
 }
 
index 474b33fca3077d2f463a87e27218d554bf5700fc..9aa6a414b3c4de8bb4b9933e320ac296d71fa955 100644 (file)
@@ -402,8 +402,7 @@ void flush_lines(int nflush)
                        flush_line(l);
                }
                nblank_lines++;
-               if (l->l_line)
-                       free((void *)l->l_line);
+               free((void *)l->l_line);
                free_line(l);
        }
        if (lines)