]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tools: Record NSS dependency on symbols file
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 16 Jul 2019 10:06:20 +0000 (12:06 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 30 Sep 2019 10:28:23 +0000 (12:28 +0200)
If a symbol file for either of NSS modules is changed then
subsequent 'make' doesn't regenerate the library, because there
is no implicit dependency between the library and symbols file.
Put an explicit dependency into the Makefile then. Unfortunately,
setting _DEPENDENCIES makes us lose automake's generated
dependencies (see src/Makefile.am:592 for details). But
fortunately, the only dependency we had was _LIBADD variable.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
tools/Makefile.am

index 29fdbfe846982bcf7facb39e10a7b67392dc9b5d..ece70384e6b426274d799c29bf3dce6d9c17e3c6 100644 (file)
@@ -535,6 +535,10 @@ nss_libnss_libvirt_la_LDFLAGS = \
 nss_libnss_libvirt_la_LIBADD = \
        nss/libnss_libvirt_impl.la
 
+nss_libnss_libvirt_la_DEPENDENCIES = \
+       $(nss_libnss_libvirt_la_LIBADD) \
+       $(LIBVIRT_NSS_SYMBOL_FILE)
+
 noinst_LTLIBRARIES += nss/libnss_libvirt_guest_impl.la
 nss_libnss_libvirt_guest_impl_la_SOURCES = \
        $(LIBVIRT_NSS_SOURCES) \
@@ -567,6 +571,10 @@ nss_libnss_libvirt_guest_la_LDFLAGS = \
 nss_libnss_libvirt_guest_la_LIBADD = \
        nss/libnss_libvirt_guest_impl.la
 
+nss_libnss_libvirt_guest_la_DEPENDENCIES = \
+       $(nss_libnss_libvirt_guest_la_LIBADD) \
+       $(LIBVIRT_GUEST_NSS_SYMBOL_FILE)
+
 lib_LTLIBRARIES = \
        nss/libnss_libvirt.la \
        nss/libnss_libvirt_guest.la