to_cast is not always talloced

diff --git a/src/lib/redis/redis.c b/src/lib/redis/redis.c
index 99ad53042dd047c82f05b7d4ee78bd1000a163b3..c19210eaec7aee6cb0e75120d337fecdd02091e0 100644 (file)
--- a/src/lib/redis/redis.c
+++ b/src/lib/redis/redis.c
@@ -281,7 +281,8 @@ int fr_redis_reply_to_value_box(TALLOC_CTX *ctx, fr_value_box_t *out, redisReply
                if (shallow) {
                        fr_value_box_bstrndup_shallow(to_cast, NULL, reply->str, reply->len, true);
                } else {
-                       if (fr_value_box_bstrndup(to_cast, to_cast, NULL, reply->str, reply->len, true) < 0) return -1;
+                       if (fr_value_box_bstrndup(to_cast->talloced ? to_cast : ctx, to_cast, NULL,
+                                                 reply->str, reply->len, true) < 0) return -1;
                }
                break;