]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
bus_driver_credentials_fill_unix_gids: Comment on a non-error
authorSimon McVittie <smcv@collabora.com>
Wed, 17 Apr 2019 13:22:15 +0000 (14:22 +0100)
committerSimon McVittie <smcv@collabora.com>
Wed, 17 Apr 2019 13:22:15 +0000 (14:22 +0100)
As described in the spec, we want GetConnectionCredentials() to report
less information, successfully, if it sees a group ID that it can't
represent.

Signed-off-by: Simon McVittie <smcv@collabora.com>
bus/driver.c

index 6714fe0625d47da59df2022fcf131c7de18a40b0..3898cfd6ba651382c2a3fb29fff007ed140756ce 100644 (file)
@@ -1939,6 +1939,9 @@ bus_driver_credentials_fill_unix_gids (DBusCredentials *credentials,
         {
           if (gids[i] > _DBUS_UINT32_MAX)
             {
+              /* At least one gid is unrepresentable, so behave as though
+               * we didn't know the group IDs at all (not an error, just
+               * success with less information) */
               dbus_free (gids_u32);
               return TRUE;
             }