staging: rtl8723bs: Efuse_WordEnableDataWrite() is not used

The function Efuse_WordEnableDataWrite() defined in rtw_efuse.c is not
used. Remove the function and code it is calling, i.e. the function
pointer (*Efuse_WordEnableDataWrite) in struct hal_ops and the function
Hal_EfuseWordEnableDataWrite() to which it points.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20250713100229.13917-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 7a74b011dedc2afaee67b278cfe864e3d61d8bd9..51cbf62c8f7d19df9dfb37bac8da76f6a7a913a9 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -286,18 +286,6 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT
        return bResult;
 }
 
-u8
-Efuse_WordEnableDataWrite(struct adapter *padapter,
-                                               u16             efuse_addr,
-                                               u8 word_en,
-                                               u8 *data,
-                                               bool            bPseudoTest)
-{
-       return padapter->HalFunc.Efuse_WordEnableDataWrite(padapter, efuse_addr,
-                                                          word_en, data,
-                                                          bPseudoTest);
-}
-
 /*-----------------------------------------------------------------------------
  * Function:   Efuse_ReadAllMap
  *

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 893cab0532ed0b3ac25bea94fc7159abac8f1dfa..3541aac605f6de2914f5d6f8d212398fd5a576b1 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1077,71 +1077,6 @@ u16 Hal_EfuseGetCurrentSize(
        return ret;
 }
 
-static u8 Hal_EfuseWordEnableDataWrite(
-       struct adapter *padapter,
-       u16 efuse_addr,
-       u8 word_en,
-       u8 *data,
-       bool bPseudoTest
-)
-{
-       u16 tmpaddr = 0;
-       u16 start_addr = efuse_addr;
-       u8 badworden = 0x0F;
-       u8 tmpdata[PGPKT_DATA_SIZE];
-
-       memset(tmpdata, 0xFF, PGPKT_DATA_SIZE);
-
-       if (!(word_en & BIT(0))) {
-               tmpaddr = start_addr;
-               efuse_OneByteWrite(padapter, start_addr++, data[0], bPseudoTest);
-               efuse_OneByteWrite(padapter, start_addr++, data[1], bPseudoTest);
-
-               efuse_OneByteRead(padapter, tmpaddr, &tmpdata[0], bPseudoTest);
-               efuse_OneByteRead(padapter, tmpaddr+1, &tmpdata[1], bPseudoTest);
-               if ((data[0] != tmpdata[0]) || (data[1] != tmpdata[1])) {
-                       badworden &= (~BIT(0));
-               }
-       }
-       if (!(word_en & BIT(1))) {
-               tmpaddr = start_addr;
-               efuse_OneByteWrite(padapter, start_addr++, data[2], bPseudoTest);
-               efuse_OneByteWrite(padapter, start_addr++, data[3], bPseudoTest);
-
-               efuse_OneByteRead(padapter, tmpaddr, &tmpdata[2], bPseudoTest);
-               efuse_OneByteRead(padapter, tmpaddr+1, &tmpdata[3], bPseudoTest);
-               if ((data[2] != tmpdata[2]) || (data[3] != tmpdata[3])) {
-                       badworden &= (~BIT(1));
-               }
-       }
-
-       if (!(word_en & BIT(2))) {
-               tmpaddr = start_addr;
-               efuse_OneByteWrite(padapter, start_addr++, data[4], bPseudoTest);
-               efuse_OneByteWrite(padapter, start_addr++, data[5], bPseudoTest);
-
-               efuse_OneByteRead(padapter, tmpaddr, &tmpdata[4], bPseudoTest);
-               efuse_OneByteRead(padapter, tmpaddr+1, &tmpdata[5], bPseudoTest);
-               if ((data[4] != tmpdata[4]) || (data[5] != tmpdata[5])) {
-                       badworden &= (~BIT(2));
-               }
-       }
-
-       if (!(word_en & BIT(3))) {
-               tmpaddr = start_addr;
-               efuse_OneByteWrite(padapter, start_addr++, data[6], bPseudoTest);
-               efuse_OneByteWrite(padapter, start_addr++, data[7], bPseudoTest);
-
-               efuse_OneByteRead(padapter, tmpaddr, &tmpdata[6], bPseudoTest);
-               efuse_OneByteRead(padapter, tmpaddr+1, &tmpdata[7], bPseudoTest);
-               if ((data[6] != tmpdata[6]) || (data[7] != tmpdata[7])) {
-                       badworden &= (~BIT(3));
-               }
-       }
-
-       return badworden;
-}
-
 static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
 {
        u32 value32;
@@ -1390,9 +1325,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
 
 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
 {
-       /*  Efuse related function */
-       pHalFunc->Efuse_WordEnableDataWrite = &Hal_EfuseWordEnableDataWrite;
-
        pHalFunc->SetHalODMVarHandler = &rtl8723b_SetHalODMVar;
 
        pHalFunc->xmit_thread_handler = &hal_xmit_handler;

diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 5dddafe035c2b6bcc87a2d96d0ed0ebc7a6c1381..da42158417735e6435c90eccacbb775d1e5577ea 100644 (file)
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -162,9 +162,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 
 struct hal_ops {
        void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
-
-       u8 (*Efuse_WordEnableDataWrite)(struct adapter *padapter, u16 efuse_addr, u8 word_en, u8 *data, bool bPseudoTest);
-
        s32 (*xmit_thread_handler)(struct adapter *padapter);
        void (*hal_notch_filter)(struct adapter *adapter, bool enable);
        void (*hal_reset_security_engine)(struct adapter *adapter);

diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index d6ea8a4a856f13e103b148d1685037c2875ca101..669565fa1c6913c78ac9ae9fef960d90c375bdd9 100644 (file)
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -96,7 +96,6 @@ u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool        bPseudo
 u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool         bPseudoTest);
 
 void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8  PwrState);
-u8 Efuse_WordEnableDataWrite(struct adapter *padapter, u16 efuse_addr, u8 word_en, u8 *data, bool bPseudoTest);
 
 u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address);
 void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest);