fbdev: omapfb: lcd_mipid: Fix an error handling path in mipid_spi_probe()

[ Upstream commit 79a3908d1ea6c35157a6d907b1a9d8ec06015e7a ]

If 'mipid_detect()' fails, we must free 'md' to avoid a memory leak.

Fixes: 66d2f99d0bb5 ("omapfb: add support for MIPI-DCS compatible LCDs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/video/fbdev/omap/lcd_mipid.c b/drivers/video/fbdev/omap/lcd_mipid.c
index a75ae0c9b14c7d4c1ba3fd966359461f1384e8c4..d1cd8785d011d74f86a6f283051540fe0c3c2113 100644 (file)
--- a/drivers/video/fbdev/omap/lcd_mipid.c
+++ b/drivers/video/fbdev/omap/lcd_mipid.c
@@ -563,11 +563,15 @@ static int mipid_spi_probe(struct spi_device *spi)
 
        r = mipid_detect(md);
        if (r < 0)
-               return r;
+               goto free_md;
 
        omapfb_register_panel(&md->panel);
 
        return 0;
+
+free_md:
+       kfree(md);
+       return r;
 }
 
 static int mipid_spi_remove(struct spi_device *spi)