]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ublk: make ublk_ctrl_stop_dev return void
authorYoav Cohen <yoav@nvidia.com>
Mon, 12 Jan 2026 22:05:00 +0000 (00:05 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 Jan 2026 22:07:31 +0000 (15:07 -0700)
This function always returns 0, so there is no need to return a value.

Signed-off-by: Yoav Cohen <yoav@nvidia.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index ec96d5afad7a88924797d86f4402d6c972b83f3a..73490890242b86924ccb447921034402a02ea6b9 100644 (file)
@@ -3459,10 +3459,9 @@ static inline void ublk_ctrl_cmd_dump(struct io_uring_cmd *cmd)
                        header->data[0], header->addr, header->len);
 }
 
-static int ublk_ctrl_stop_dev(struct ublk_device *ub)
+static void ublk_ctrl_stop_dev(struct ublk_device *ub)
 {
        ublk_stop_dev(ub);
-       return 0;
 }
 
 static int ublk_ctrl_get_dev_info(struct ublk_device *ub,
@@ -3935,7 +3934,8 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd,
                ret = ublk_ctrl_start_dev(ub, header);
                break;
        case UBLK_CMD_STOP_DEV:
-               ret = ublk_ctrl_stop_dev(ub);
+               ublk_ctrl_stop_dev(ub);
+               ret = 0;
                break;
        case UBLK_CMD_GET_DEV_INFO:
        case UBLK_CMD_GET_DEV_INFO2: