]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: rzv2h-rspi: remove call to spi_finalize_current_transfer()
authorCosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Mon, 1 Dec 2025 13:42:18 +0000 (15:42 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:38:29 +0000 (19:38 +0900)
A call to spi_finalize_current_transfer() is only needed when the SPI
transfer is completed outside of the current context, when the
.transfer_one() implementation returns > 0.

Since the SPI transfer is completed in the current context, and we
return 0 from .transfer_one(), the SPI core assumes that the transfer
has completed and it does not wait for the completion variable that
would be set by a call to spi_finalize_current_transfer().

Remove the call to spi_finalize_current_transfer().

Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Link: https://patch.msgid.link/20251201134229.600817-3-cosmin-gabriel.tanislav.xa@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rzv2h-rspi.c

index 8cffc9cb6b6bf9c903659ca86cfaa7aed18d3f33..beea4fb83d103b3dd0fc5428961e8f8fc56af06b 100644 (file)
@@ -250,8 +250,6 @@ static int rzv2h_rspi_transfer_one(struct spi_controller *controller,
        if (ret)
                transfer->error = SPI_TRANS_FAIL_IO;
 
-       spi_finalize_current_transfer(controller);
-
        return ret;
 }